migrate pallet-mixnet to umbrella crate #6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UtkarshBhardwaj007
added
R0-silent
|
Part of #6504 |
seadanda
reviewed
Dec 24, 2024
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
kianenigma
reviewed
Dec 26, 2024
kianenigma
reviewed
Dec 26, 2024
kianenigma
reviewed
Dec 31, 2024
| @@ -168,12 +163,9 @@ fn twox<BlockNumber: UniqueSaturatedInto<u64>>( | |||
| // The pallet | |||
| //////////////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| #[frame_support::pallet(dev_mode)] | |||
| #[frame::pallet(dev_mode)] | |||
There was a problem hiding this comment.
This dev_mode is not really good for production as well 🙈 not in scope for now, but should be removed later.
There was a problem hiding this comment.
I see, will have to dig in the code to understand why but we could create an issue for it if there's isn't one already.
There was a problem hiding this comment.
Think this is just because I never got around to adding weights.
kianenigma
approved these changes
Dec 31, 2024
|
Review required! Latest push from author must always be reviewed |
ggwpez
reviewed
Jan 2, 2025
ggwpez
approved these changes
Jan 2, 2025
ggwpez
reviewed
Jan 2, 2025
91 tasks
re-gius
approved these changes
Jan 3, 2025
Merged
via the queue into
paritytech:master
with commit Jan 3, 2025
f3ab385
199 of 203 checks passed
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
# Description Migrate pallet-mixnet to use umbrella crate whilst adding a few types and traits in the frame prelude that are used by other pallets as well. ## Review Notes * This PR migrates `pallet-mixnet` to use the umbrella crate. * Note that some imports like `use sp_application_crypto::RuntimeAppPublic;` and imports from `sp_mixnet::types::` have not been migrated to the umbrella crate as they are not used in any / many other places and are relevant only to the `pallet-mixnet`. * Transaction related helpers to submit transactions from `frame-system` have been added to the main `prelude` as they have usage across various pallets. ```Rust pub use frame_system::offchain::*; ``` * Exporting `arithmetic` module in the main `prelude` since this is used a lot throughout various pallets. * Nightly formatting has been applied using `cargo fmt` * Benchmarking dependencies have been removed from`palet-mixnet` as there is no benchmarking.rs present for `pallet-mixnet`. For the same reason, `"pallet-mixnet?/runtime-benchmarks"` has been removed from `umbrella/Cargo.toml`. --------- Co-authored-by: Dónal Murray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate pallet-mixnet to use umbrella crate whilst adding a few types and traits in the frame prelude that are used by other pallets as well.
Review Notes
pallet-mixnetto use the umbrella crate.use sp_application_crypto::RuntimeAppPublic;and imports fromsp_mixnet::types::have not been migrated to the umbrella crate as they are not used in any / many other places and are relevant only to thepallet-mixnet.frame-systemhave been added to the mainpreludeas they have usage across various pallets.arithmeticmodule in the mainpreludesince this is used a lot throughout various pallets.cargo fmtpalet-mixnetas there is no benchmarking.rs present forpallet-mixnet. For the same reason,"pallet-mixnet?/runtime-benchmarks"has been removed fromumbrella/Cargo.toml.